Adding MacAddress, MacAddress8#162
Open
mrengineer7777 wants to merge 2 commits intoarduino:masterfrom
Open
Conversation
Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works. If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes. This library originated on arduino-esp32 (espressif/arduino-esp32#6667). It was suggested that I contribute to the Arduino core as well :)
|
|
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 13 13
Lines 827 827
=======================================
Hits 794 794
Misses 33 33 Continue to review full report at Codecov.
|
Added printTo(). Added index operators and type converters. See test project here: https://github.com/mrengineer7777/MA_Test. No further changes expected.
Author
|
Final version, ready for review. See test project here: https://github.com/mrengineer7777/MA_Test |
Author
|
It seems there is no interest so I will be deleting this PR soon. |
Contributor
|
Sorry, this fell through the cracks. In any case adding test code would be much appreciated. @facchinm what do you think re integrating this to the core API? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works (edit: see updates below). If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes.
This library originated on arduino-esp32 (espressif/arduino-esp32#6667). It was suggested that I contribute to the Arduino core as well :)